Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing announcement when comments are disabled #12558

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

There's no warning message for disabled comments in frontend. This PR adds it.

馃搶 Related Issues

Testing

  1. Log in as administrator.
  2. Enter the admin panel and navigate to a process that have a proposals component with comments enabled.
  3. Block comments in that component in the steps settings.
  4. Navigate to a proposal on the frontend where comments have been blocked.
  5. See that no comments can be submitted and there is a warning message indicating that comments have been disabled

馃摲 Screenshots

Screenshot of the warning message

鈾ワ笍 Thank you!

@andreslucena andreslucena added module: comments type: fix PRs that implement a fix for a bug labels Mar 4, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 4, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 4, 2024
@andreslucena andreslucena changed the title Fix showing announcement when comments are disabled Fix showing announcement when comments are disabled Mar 4, 2024
@andreslucena andreslucena force-pushed the fix/comments-disabled-announcement branch from 6949757 to 5566b02 Compare March 4, 2024 18:17
github-actions[bot]
github-actions bot previously approved these changes Mar 4, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 5, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 6, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 12, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 12, 2024
github-actions[bot]
github-actions bot previously approved these changes May 9, 2024
github-actions[bot]
github-actions bot previously approved these changes May 22, 2024
github-actions[bot]
github-actions bot previously approved these changes May 23, 2024
@andreslucena andreslucena marked this pull request as ready for review May 23, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 馃憖 In review
Development

Successfully merging this pull request may close these issues.

Missing warning message for disabled comments in frontend
2 participants