Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Backport 'Fix bugs in details of RTL' to v0.28 (#12495)" #12564

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

We've backported a fix for RTL but it's a new feature from Tailwind that isn't supported in the version that we're using in v0.28.

This was detected by @microstudi:

#12495 (comment)

This PR reverts the backport that introduced the bug in v0.28

📌 Related Issues

Testing

To check the bug:

  1. Run these commands:
git checkout release/0.28-stable
bundle exec rake development_app
  1. Go to the footer and click in the "Cookie settings" to open the modal. See that's broken
  2. Go to the login page http://localhost:3000/users/sign_in. See that the input button for showing the password is broken

📷 Screenshots

Bug of the modal
Bug of the link in the login page

♥️ Thank you!

@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Mar 5, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu added this to the 0.28.1 milestone Mar 11, 2024
@alecslupu alecslupu merged commit 79747c9 into release/0.28-stable Mar 11, 2024
103 of 105 checks passed
@alecslupu alecslupu deleted the backport/0.28/revert/12495-fix-bugs-in-details-of-rtl-12390 branch March 11, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants