New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customisble footer revamp (pages & topics) #12592
base: develop
Are you sure you want to change the base?
Customisble footer revamp (pages & topics) #12592
Conversation
…der method helper in controller
Somethings that I noticed during a quick review:
This is how it looks like now: And this is how it should look according to the mockup: So, we need to move the column from the right to the bottom of the Resources column
They're mixed, as according to the specs it should be the inverse. Compare the names of the mockup and the screenshot. Updating to what we have now:
As we're removing an element that was until now in the footer (the Help link) I think we should change the seed so this topic is visible by before (adding the "show in footer" checkbox enable by default)
|
decidim-core/app/views/layouts/decidim/footer/_main_legal.html.erb
Outdated
Show resolved
Hide resolved
….erb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena referencing comment: #12574 (comment) @carolromero is happy with us proceeding with the 4 column approach as posed to one under the grid. All requested changes have been made according to your initial review. This is now ready for another review. |
🎩 What? Why?
A duplicate link with the same path to
/pages/terms-of-service
is removed to allow for only one needed in the Decidim instance.Edit: After a review with @decidim/product, the following changes have now taken place:
📌 Related Issues
Testing
📷 Screenshots