Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customisble footer revamp (pages & topics) #12592

Open
wants to merge 61 commits into
base: develop
Choose a base branch
from

Conversation

greenwoodt
Copy link
Contributor

@greenwoodt greenwoodt commented Mar 14, 2024

🎩 What? Why?

A duplicate link with the same path to /pages/terms-of-service is removed to allow for only one needed in the Decidim instance.

Edit: After a review with @decidim/product, the following changes have now taken place:

  • Removal of the 'Help' link from the Decidim column.
  • Removal of duplicate 'Terms of Service' link.
  • Rearrangement of the three columns (and four sections).
  • Remove "show in footer" checkbox for pages. Leave the checkbox only for topics.
  • Rename topic name from "General Help" to "Help"
  • Rename column header from "General Help" to "General"

📌 Related Issues

Testing

📷 Screenshots

♥️ Thank you!

@greenwoodt greenwoodt added module: core type: fix PRs that implement a fix for a bug labels Mar 14, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 14, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 14, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 14, 2024
@greenwoodt greenwoodt marked this pull request as ready for review March 14, 2024 15:40
github-actions[bot]
github-actions bot previously approved these changes Mar 14, 2024
@greenwoodt greenwoodt added the backport Pull Requests that are a backport for a fixed bug label Mar 14, 2024
@greenwoodt greenwoodt changed the title Customisble footer links Customisble footer pages without topics Mar 14, 2024
@greenwoodt greenwoodt added this to the 0.29.0 milestone Mar 14, 2024
@greenwoodt greenwoodt added status: WIP and removed backport Pull Requests that are a backport for a fixed bug labels Mar 14, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 23, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 24, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 24, 2024
@andreslucena
Copy link
Member

andreslucena commented Apr 30, 2024

Somethings that I noticed during a quick review:

  1. About the design
  • Rearrangement of the three columns (and four sections)

This is how it looks like now:

Screenshot of the footer section

And this is how it should look according to the mockup:

Mockup

So, we need to move the column from the right to the bottom of the Resources column

  1. About the name of the topic and the column

Rename topic name from "General Help" to "Help"
Rename column header from "General Help" to "General"

They're mixed, as according to the specs it should be the inverse. Compare the names of the mockup and the screenshot. Updating to what we have now:

  • Rename column header from "General" to "Help"
  • Rename topic name from "Help" to "General"
  1. About the discoverability

As we're removing an element that was until now in the footer (the Help link) I think we should change the seed so this topic is visible by before (adding the "show in footer" checkbox enable by default)

  • Make the "show in footer" checkbox enabled by default in the seeds

….erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes May 8, 2024
github-actions[bot]
github-actions bot previously approved these changes May 8, 2024
github-actions[bot]
github-actions bot previously approved these changes May 9, 2024
@greenwoodt
Copy link
Contributor Author

@andreslucena referencing comment: #12574 (comment) @carolromero is happy with us proceeding with the 4 column approach as posed to one under the grid.

All requested changes have been made according to your initial review. This is now ready for another review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Problems with the footer and pages/themes
2 participants