Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Improve performance on comment rendering' to v0.28 #12595

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #12582 to v0.28

♥️ Thank you!

* use exists? instead of full collection traversal

* Add counter cache on cells

* replace query with counter cached version
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: comments type: fix PRs that implement a fix for a bug labels Mar 14, 2024
@andreslucena andreslucena marked this pull request as draft March 14, 2024 17:46
@andreslucena
Copy link
Member Author

This needs to be merged after #12602

Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreslucena #12602 has been merged, can you rebase? thx

@andreslucena andreslucena marked this pull request as ready for review March 15, 2024 09:31
@alecslupu alecslupu added this to the 0.28.1 milestone Mar 15, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit c61906c into release/0.28-stable Mar 15, 2024
60 checks passed
@alecslupu alecslupu deleted the backport/0.28/improve-performance-on-comment-12582 branch March 15, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: comments type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants