Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix display of the online meeting link' to v0.28 #12598

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #12467 to v0.28

♥️ Thank you!

* change in model and view to alter behaviour of meeting

* Update decidim-meetings/app/models/decidim/meetings/meeting.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Moving condition to decidim-core online.erb

* Tests for regsitered and signed users

* fixed rubocop issues

* Update decidim-meetings/app/cells/decidim/meetings/dates_and_map/show.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-core/app/cells/decidim/address/online.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-meetings/spec/system/live_meeting_access_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update to live meeting access spec and fix to map using model

* Changed to address_cell.rb with method added

* Update decidim-core/app/cells/decidim/address_cell.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-meetings/spec/system/live_meeting_access_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-meetings/spec/system/live_meeting_access_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-meetings/spec/system/live_meeting_access_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-meetings/spec/system/live_meeting_access_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug contract: redesign Barcelona City Council contract module: meetings type: fix PRs that implement a fix for a bug labels Mar 15, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 15, 2024
@alecslupu alecslupu self-assigned this Mar 15, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit de12a0d into release/0.28-stable Mar 15, 2024
103 checks passed
@alecslupu alecslupu deleted the backport/0.28/fix-display-of-the-online-meet-12467 branch March 15, 2024 09:41
@alecslupu alecslupu added this to the 0.28.1 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug contract: redesign Barcelona City Council contract module: meetings type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants