Refactor malformed titles in admin logs (part 1)

decidim-core/app/presenters/decidim/log/resource_presenter.rb

@@ -10,6 +10,8 @@ module Log
     # overwrite `BasePresenter#resource_presenter` to return your custom resource presenter.
     # The only requirement for custom renderers is that they should respond to `present`.
     class ResourcePresenter
+      include Decidim::SanitizeHelper
+
       # Public: Initializes the presenter.
       #
       # resource - An instance of a model that can be located by
@@ -65,7 +67,11 @@ def resource_path
       #
       # Returns an HTML-safe String.
       def present_resource_name
-        h.translated_attribute extra["title"]
+        if resource.present? && resource.respond_to?(:presenter) && resource.presenter.respond_to?(:title)
+          resource.presenter.title(html_escape: true)
+        else
+          decidim_escape_translated(extra["title"]).html_safe
+        end
       end
     end
   end

decidim-core/app/services/decidim/log/diff_changeset_calculator.rb

@@ -86,7 +86,7 @@ def generate_i18n_changeset(attribute, values, type)
         locales.flat_map do |locale|
           previous_value = values.first.try(:[], locale)
           new_value = values.last.try(:[], locale)
-          if previous_value == new_value
+          if previous_value == new_value || (previous_value.nil? && new_value.blank?)
             nil
           else
             label = generate_label(attribute, locale)

decidim-debates/app/models/decidim/debates/debate.rb

@@ -56,6 +56,12 @@ class Debate < Debates::ApplicationRecord
       }
       scope_search_multi :with_any_state, [:open, :closed]
 
+      # Returns the presenter for this author, to be used in the views.
+      # Required by ResourceRenderer.
+      def presenter
+        Decidim::Debates::DebatePresenter.new(self)
+      end
+
       def self.log_presenter_class_for(_log)
         Decidim::Debates::AdminLog::DebatePresenter
       end

decidim-debates/app/presenters/decidim/debates/admin_log/debate_presenter.rb

@@ -15,10 +15,6 @@ module AdminLog
       class DebatePresenter < Decidim::Log::BasePresenter
         private
 
-        def resource_presenter
-          @resource_presenter ||= Decidim::Debates::Log::ResourcePresenter.new(action_log.resource, h, action_log.extra["resource"])
-        end
-
         def diff_fields_mapping
           {
             description: "Decidim::Debates::AdminLog::ValueTypes::DebateTitleDescriptionPresenter",

decidim-meetings/app/presenters/decidim/meetings/admin_log/meeting_presenter.rb

@@ -15,10 +15,6 @@ module AdminLog
       class MeetingPresenter < Decidim::Log::BasePresenter
         private
 
-        def resource_presenter
-          @resource_presenter ||= Decidim::Meetings::Log::ResourcePresenter.new(action_log.resource, h, action_log.extra["resource"])
-        end
-
         def diff_fields_mapping
           {
             address: :string,

decidim-proposals/app/presenters/decidim/proposals/admin_log/proposal_presenter.rb

@@ -15,13 +15,9 @@ module AdminLog
       class ProposalPresenter < Decidim::Log::BasePresenter
         private
 
-        def resource_presenter
-          @resource_presenter ||= Decidim::Proposals::Log::ResourcePresenter.new(action_log.resource, h, action_log.extra["resource"])
-        end
-
         def diff_fields_mapping
           {
-            title: "Decidim::Proposals::AdminLog::ValueTypes::ProposalTitleBodyPresenter",
+            title: :i18n,
             body: "Decidim::Proposals::AdminLog::ValueTypes::ProposalTitleBodyPresenter",
             state: "Decidim::Proposals::AdminLog::ValueTypes::ProposalStatePresenter",
             answered_at: :date,

decidim-proposals/app/presenters/decidim/proposals/log/valuation_assignment_presenter.rb

@@ -11,7 +11,7 @@ class ValuationAssignmentPresenter < Decidim::Log::ResourcePresenter
         # Returns an HTML-safe String.
         def present_resource_name
           if resource.present?
-            Decidim::Proposals::ProposalPresenter.new(resource.proposal).title
+            resource.proposal.presenter.title(html_escape: true)
           else
             super
           end

decidim-proposals/spec/presenters/decidim/proposals/log/resource_presenter_spec.rb → decidim-proposals/spec/presenters/decidim/log/resource_presenter_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe Decidim::Proposals::Log::ResourcePresenter, type: :helper do
+describe Decidim::Log::ResourcePresenter, type: :helper do
   let(:presenter) { described_class.new(resource, helper, extra) }
   let(:resource) { create(:proposal, title: Faker::Book.unique.title) }
   let(:extra) do
@@ -12,11 +12,6 @@
   end
   let(:resource_path) { Decidim::ResourceLocatorPresenter.new(resource).path }
 
-  before do
-    helper.extend(Decidim::ApplicationHelper)
-    helper.extend(Decidim::TranslationsHelper)
-  end
-
   context "when the resource exists" do
     it "links to its public page with the name of the proposal" do
       html = presenter.present