Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Hide last activities on breadcrumb dropdown when organization...' to v0.28 #12719

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #12685 to v0.28

♥️ Thank you!

…igured to force authentication

* Do not display latest activities cell for not signed in users and forced authentication

* Add test

* Use safe navigation operator

* Update decidim-core/spec/system/homepage_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Hide promoted space from menu dropdown if not signed in user and forced authentication

* Update decidim-core/spec/system/homepage_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Apr 24, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 24, 2024
@andreslucena andreslucena changed the title Backport 'Hide last activities on breadcrumb dropdown when organization is configured to force authentication' to v0.28 Backport 'Hide last activities on breadcrumb dropdown when organization...' to v0.28 Apr 24, 2024
@alecslupu alecslupu added this to the 0.28.1 milestone Apr 24, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 06f8c99 into release/0.28-stable Apr 24, 2024
103 checks passed
@alecslupu alecslupu deleted the backport/0.28/hide-last-activities-on-breadc-12685 branch April 24, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants