Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Display endorsements after debate's closure' to v0.28 #12720

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #12680 to v0.28

♥️ Thank you!

* extration of not_hidden method from proposal applied to debates includer method helper in controller

* returned to normal

* condition added to invoke endorsements after closure

* rspec test created for feature

* changes based on review

* Update show.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-debates/app/views/decidim/debates/debates/show.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: debates type: fix PRs that implement a fix for a bug labels Apr 24, 2024
@alecslupu alecslupu added this to the 0.28.1 milestone Apr 24, 2024
@alecslupu alecslupu self-assigned this Apr 24, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 69cc5ff into release/0.28-stable Apr 24, 2024
39 checks passed
@alecslupu alecslupu deleted the backport/0.28/display-endorsements-after-deb-12680 branch April 24, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: debates type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants