Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Do not show scopes column in budgets if there isn't subscopes' to v0.28 #12738

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #12020 to v0.28

♥️ Thank you!

* update to budget form to allow edit of scope in component

* logic fixed in form

* conditional logic added to view in budgets

* reworked logic for front end

* test added for subscopes in BUDGETS

* logic added now to projects

* rspec test added to PROJECTS

* lint error in spelling

* Test suite to manage scope detection when no subscopes are enabled -  updated

* lint code syntax correction
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: admin module: budgets type: fix PRs that implement a fix for a bug labels Apr 25, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 25, 2024
@alecslupu alecslupu added this to the 0.28.1 milestone Apr 25, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 1755614 into release/0.28-stable Apr 25, 2024
43 checks passed
@alecslupu alecslupu deleted the backport/0.28/do-not-show-scopes-column-in-b-12020 branch April 25, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: admin module: budgets type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants