Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix flaky shakapacker compilation' to v0.27 #12781

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #12635 to v0.27

♥️ Thank you!

* Compile shakapacker in all the spec types

* Add extra controls to ease up debugging flaky spec

* Add debugging message in Shakapacker compilation failure
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug flaky spec module: core type: fix PRs that implement a fix for a bug labels Apr 26, 2024
@alecslupu alecslupu added this to the 0.27.6 milestone Apr 29, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu
Copy link
Contributor

@andreslucena This one has failed, can you have a look ?

@andreslucena
Copy link
Member Author

@andreslucena This one has failed, can you have a look ?

@alecslupu it was a flaky, now it is working and can be merged

@alecslupu alecslupu merged commit 42d21a5 into release/0.27-stable Apr 29, 2024
42 checks passed
@alecslupu alecslupu deleted the backport/0.27/fix-flaky-shakapacker-compilat-12635 branch April 29, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug flaky spec module: core module: dev type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants