Backport 'Add votes count to comment caches' to v0.27 #12782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add votes count to comment caches
* Use size instead of count method
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
* Implement counter_cache for comment's votes
We need to handle the counter_cache manually as we have an scoped
association (i.e. with the lambda that does the where in the relation)
> has_many :up_votes, -> { where(weight: 1) }
So, for this reason we need to do handle the update with a callback in
CommentVote and can't use the reset_counters in the migration.
* Explicitly use the counter_cache attributes in comment cell
---------
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
andreslucena
added
backport
alecslupu
deleted the
backport/0.27/add-votes-count-to-comment-cac-12551
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #12551 to v0.27