Backport 'Allow deletion of categories when there are no resources associated' to v0.27 #12808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Destroy categorization when resource is being destroyed * Add rake task and RELEASE NOTES * Fix template * Prevent destroy command to remove categories in use * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-core/lib/decidim/core/test/shared_examples/has_category.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Running linters --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
added
backport
andreslucena
force-pushed
the
backport/0.27/allow-deletion-of-categories-w-12143
branch
from
56ed178
to
5e2ac20
Compare
alecslupu
requested changes
Apr 30, 2024
| <% if allowed_to? :destroy, :category, category: subcategory %> | ||
| <%= icon_link_to "circle-x", category_path(current_participatory_space, subcategory), t("actions.destroy", scope: "decidim.admin"), class: "action-icon--remove", method: :delete, data: { confirm: t("actions.confirm_destroy", scope: "decidim.admin") } %> | ||
| <% if subcategory.unused? %> | ||
| <% if allowed_to? :destroy, :category, category: subcategory %> |
There was a problem hiding this comment.
There are 2 if statements, and they are flipped
Suggested in code review
alecslupu
reviewed
Apr 30, 2024
decidim-admin/app/views/decidim/admin/categories/index.html.erb
Outdated
Show resolved
Hide resolved
alecslupu
requested changes
Apr 30, 2024
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
deleted the
backport/0.27/allow-deletion-of-categories-w-12143
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #12143 to v0.27