Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meetings documents as collections in participatory spaces landing pages #12866

Merged
merged 18 commits into from
Jun 10, 2024
Merged

Add meetings documents as collections in participatory spaces landing pages #12866

merged 18 commits into from
Jun 10, 2024

Conversation

entantoencuanto
Copy link
Contributor

@entantoencuanto entantoencuanto commented May 17, 2024 •
edited

🎩 What? Why?

This PR:

  • Defines a ComponentAttachmentCollectionPresenter class to present the documents of a components as an attachment collection
  • Allows to include in documents panel cell additional documents collections of components and uses it in participatory spaces documents content blocks with the previously described presenter for published meeting components. Each component documents collection is shown in a folder named with the name of the component
  • Adds some system tests and some more for the presenter

📌 Related Issues

Testing

  • As admin:
    • Publish a meetings component in a participatory space, publish a meeting on it and attach a document (it can be inside a folder too)
    • Add the related documents content block to the landing page of the participatory space
  • As any user visit the landing page of the participatory space. A folder named as "component name Documents" should include the previously defined attachment with the rest of documents attached to the other meetings published in the component if present

The feature can be checked at https://decidim-lot2.populate.tools/processes/polls-in-meetings. The example process has a component with a meeting and a PDF document attached

📷 Screenshots

meetings_documents.webm

@entantoencuanto entantoencuanto marked this pull request as draft May 17, 2024 18:23
@entantoencuanto entantoencuanto added the type: feature PRs or issues that implement a new feature label May 17, 2024
github-actions[bot]
github-actions bot previously approved these changes May 17, 2024
View reviewed changes
@entantoencuanto entantoencuanto added the contract: 2024-developments Barcelona City Council contract label May 17, 2024
@entantoencuanto entantoencuanto force-pushed the feature/meetings_documents_in_spaces branch from ed5ac25 to fa095c8 Compare May 20, 2024 17:52
github-actions[bot]
github-actions bot previously approved these changes May 20, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes May 20, 2024
View reviewed changes
@andreslucena
Copy link
Member

@entantoencuanto can you provide a description for the PR 🙏🏽 ?

FYI, this is how it looks in my email this PR:

Screenshot of the notification in the email

This also means that even though you've updated the description, the body of the first email in the thread isn't updated, so that's always there.

github-actions[bot]
github-actions bot previously approved these changes May 21, 2024
View reviewed changes
@entantoencuanto
Copy link
Contributor Author

I'm sorry, I published the PR by mistake before updating the description

@entantoencuanto entantoencuanto force-pushed the feature/meetings_documents_in_spaces branch from 7cb2945 to 519aac9 Compare May 21, 2024 16:33
@entantoencuanto entantoencuanto marked this pull request as ready for review May 21, 2024 17:34
@alecslupu alecslupu self-assigned this May 21, 2024
@furilo furilo requested review from ferblape and furilo May 21, 2024 20:08
github-actions[bot]
github-actions bot previously approved these changes May 29, 2024
View reviewed changes
NilHomedes
NilHomedes previously approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!
Thanks @entantoencuanto :)

andreslucena
andreslucena requested changes May 30, 2024
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of suggestions, one doubt, and found a minor bug.

Great usage of the decorator, it makes it really easy to read it.

decidim-core/lib/decidim/core/test/shared_examples/has_attachments.rb Outdated Show resolved Hide resolved
decidim-core/app/presenters/decidim/component_attachment_collection_presenter.rb Outdated Show resolved Hide resolved
decidim-core/config/locales/en.yml Outdated Show resolved Hide resolved
decidim-core/app/cells/decidim/content_blocks/participatory_space_documents_cell.rb Outdated Show resolved Hide resolved
@entantoencuanto
Copy link
Contributor Author

I'm going to add the pending changes tomorrow

github-actions[bot]
github-actions bot previously approved these changes Jun 5, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jun 5, 2024
View reviewed changes
@entantoencuanto @andreslucena
Update decidim-core/lib/decidim/core/test/shared_examples/has_attachm…
4fd7168 
…ents.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Jun 5, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jun 5, 2024
View reviewed changes
andreslucena
andreslucena approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena merged commit 0376e6d into develop Jun 10, 2024
110 checks passed
@andreslucena andreslucena deleted the feature/meetings_documents_in_spaces branch June 10, 2024 09:13
entantoencuanto added a commit that referenced this pull request Jun 12, 2024
@entantoencuanto
Merge branch 'feature/proposals-admins-filters-and-navigation' into s…
c13be56 
…taging-lot2

* feature/proposals-admins-filters-and-navigation:
  Store filters selections in session and allow removing all filters
  Fix flaky spec on organization form (comment max length) (#12985)
  Fix stying in participatory texts (#12986)
  Fix proposal bulk actions buttons display (#12987)
  Add meetings documents as collections in participatory spaces landing pages (#12866)
  Remove initializer that updates the proposal status when linked in results (#12948)
  Standarise ```current_user``` call within Commands tasks (Verifications) (#12960)
  Upgrade Github actions (#12977)
  Add multiselect/tom-select to Design Guide's form page (#12961)
  Rename Support to Vote in proposals (#12873)
  Fix flaky specs in comment search (#12899)
  Fix submit on enter in forms with Datepicker (#12889)
  Fix flaky spec with multilingual organization name leftover (#12954)
  Fix flaky related to `Decidim.available_locales` (#12959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions approved these changes

@ferblape ferblape ferblape left review comments

@furilo furilo furilo left review comments

@NilHomedes NilHomedes NilHomedes left review comments

Assignees

@andreslucena andreslucena

Labels
configuration contract: 2024-developments Barcelona City Council contract module: core type: feature PRs or issues that implement a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show attached documents from meetings in the spaces' documents
6 participants
@entantoencuanto @andreslucena @ferblape @furilo @NilHomedes @alecslupu