Standardise current_user call within Commands tasks (Core)
#12988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenwoodt
added
module: core
type: change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…d with standardization
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
requested changes
Jul 3, 2024
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
reviewed
Jul 3, 2024
decidim-core/app/controllers/decidim/devise/passwords_controller.rb
Outdated
Show resolved
Hide resolved
mllocs
pushed a commit
that referenced
this pull request
Jul 18, 2024
) * delete follow commnand refactored in core * updated controller of delete and follow. Updated create follow command with standardization * arugements removed and rpsec deletefollow improved * update to create admin command in the createfollow follow call * update to calls on join_meeting and create_debate * delegation added to create follow and updated specs * updated arugement call in initatives command * updated calls in conferences and meetings * updated create meeting spec calls * create follow call updated * update to calls in assembiles and Participatory processes * create follow command delegated * create follow call in import assembly argument removed * update draft amendmentable standardised * publish draft in amendenables standardized * create draft standardised * promote command delegated * delegation created with update to test as a loop is created within the block * create report delegated to current_user and spec updated * update_password command delegated * destroy form delegated and spec updated * update account delegated and spec fixed * update_user_interested delegated and spec fixed * update notifiction settings delegated and spec updated * syntax updates * update to arguments in reports controller * update of calls of destroy account * update to controllers * ignores deleted user arguement removed * update to tests * admin passewords spec fixed * reverting changes to update_password command * delegation test in update and destroy * removed prefix * Update decidim-core/app/commands/decidim/destroy_account.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-core/app/commands/decidim/destroy_account.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-core/app/commands/decidim/destroy_account.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * lint code update * Update decidim-core/app/commands/decidim/destroy_account.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-core/app/commands/decidim/destroy_account.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-core/app/commands/decidim/destroy_account.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * pushing update changes * updates to test suite in propoals and core * Apply suggestions from code review --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR standardises the
current_usercommand files within the Decidim's Core module.📌 Related Issues
Testing
📷 Screenshots