Enable admins answer to closed comments #13027
Conversation
This is done mainly because some modules (such as Initiatives) don't have the feature for blocking the comments in the steps (as they don't have steps as a Participatory Process)
…answers_close_comments
|
It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andreslucena
added
the
contract: 2024-developments
There was a problem hiding this comment.
Nice job @ElviaBth, I've just left you a couple of aestic comments.
However there one thing that needs to be completed, a couple of tests.
We should add all the cases that the new condition checks in the comments_examples.rb
decidim-admin/app/controllers/concerns/decidim/admin/needs_admin_tos_accepted.rb
Outdated
Show resolved
Hide resolved
decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
Outdated
Show resolved
Hide resolved
decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
Outdated
Show resolved
Hide resolved
decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
Outdated
Show resolved
Hide resolved
decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
Outdated
Show resolved
Hide resolved
decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
Outdated
Show resolved
Hide resolved
| let!(:component) { create(:component, organization:) } | ||
| let(:body) { "This is a new comment" } | ||
| let(:alignment) { 1 } | ||
| let(:user_group) { create(:user_group, :verified) } | ||
| let(:user_group_id) { user_group.id } | ||
|
|
||
| let(:commentable) { create(:dummy_resource) } | ||
| let(:commentable) { create(:dummy_resource, accepts_new_comments?: false) } |
There was a problem hiding this comment.
By default, the resource should allow comments, so this should stay as it was.
Then, check that a normal user can make comments.
After that create a context where the commentable does not accepts comments (with this let entry in there). Then check that a normal user cannot create a comment but admins can
🎩 What? Why?
This PR enables administrators to answer comments or post new ones even after they are closed to participants.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
warning message for blocked comments