Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all the authorizations available for the organization in the admin #13029

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

It was detected that some verifications that were enabled for the Organization weren't available in the admin panel.

This PR adds them.

As we could list custom verifications made by the implementers we have a default help text to explain to developers that they need to add these strings. I've also added instructions in the Releases Notes to let the implementers/developers about this new feature.

📌 Related Issues

Testing

  1. Sign in as system administrator
  2. Go to the verifications method for any organization (i.e. http://localhost:3000/system/organizations/1/edit)
  3. Check that you have all the methods enabled
  4. Sign in as administrator in that organization
  5. Go to http://localhost:3000/admin/authorization_workflows
  6. See that you have all the methods that you've seen before

To test the missing message you can remove any of the help strings introduced in the i18n file.

📷 Screenshots

Admin panel with all the verifications

♥️ Thank you!

@andreslucena andreslucena added the type: feature PRs or issues that implement a new feature label Jun 20, 2024
@andreslucena andreslucena force-pushed the feature/show-direct-verifications-admin branch from 5469481 to 7ce8e7e Compare June 20, 2024 08:26
github-actions[bot]
github-actions bot previously approved these changes Jun 20, 2024
@alecslupu alecslupu self-assigned this Jun 21, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alecslupu alecslupu merged commit 9b255fa into develop Jun 21, 2024
110 of 111 checks passed
@alecslupu alecslupu deleted the feature/show-direct-verifications-admin branch June 21, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Show all the verifications at /admin/authorization_workflows
2 participants