Fix timeline entries display in result page #13033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andreslucena
force-pushed
the
fix/accountability-timeline
branch
from
109a9ad
to
d33581a
Compare
|
In a meeting with @decidim/product we mentioned that we need to actually show the result children too in this page. I'll mark this as draft until I fix that |
|
Adding the |
mllocs
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Fix timeline entries display in result page * Fix rspec description (copy and paste error) * Prevent XSS in timeline entries * Add spec * Show subresults in result page * Link back to parent result on subresults page * Prevent showing an empty element in the breadcrumb on the parent result page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
With the redesign we have removed the Timeline entries from a Result page in Accountability. This PR fixes it.
Although the code was showing children results as timeline entries, these are different things. Also, to clarify, as a Subresult can't have more children results, it doesn't make sense to show them in this page.After diving in Legacy and seeing how the Ancient people wanted this to work (and specially talking with @carolromero a lot about this feature and this page), we have the following result:
Testing
📷 Screenshots