Change background color for PWA from primary to white #13034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andreslucena
changed the title
andreslucena
force-pushed
the
fix/pwa-background-color
branch
from
8429ca0
to
0a004ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
With the redesign we have removed the theme color from the PWA, and we're reusing the primary color.
This generated a bug as although it works for the top bar of the PWA, it doesn't work for the
backgroundcolor. You can check it out by adding https://meta.decidim.org to your home screen in a mobile device and then opening the app:We've talked about adding the theme color (again) to the Appearence settings, or adding the background color as a setting there. But we think this is giving yet another setting and also it's something else that we need to explain/document, etc.
📌 Related Issues
Testing