Add 'evaluating' state to proposal answers #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
===========================================
- Coverage 96.99% 64.28% -32.71%
===========================================
Files 500 56 -444
Lines 8549 994 -7555
===========================================
- Hits 8292 639 -7653
- Misses 257 355 +98 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
===========================================
- Coverage 96.99% 64.28% -32.71%
===========================================
Files 500 56 -444
Lines 8549 994 -7555
===========================================
- Hits 8292 639 -7653
- Misses 257 355 +98 |
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
- Coverage 96.99% 96.96% -0.04%
==========================================
Files 500 500
Lines 8549 8556 +7
==========================================
+ Hits 8292 8296 +4
- Misses 257 260 +3 |
ghost
added
the
mrcasals
reviewed
Jul 19, 2017
| @@ -17,10 +17,13 @@ module ApplicationHelper | |||
| # | |||
| # Returns a String. | |||
| def humanize_proposal_state(state) | |||
| value = if state == "accepted" | |||
| value = case state | |||
There was a problem hiding this comment.
This method smells. Can you use i18n defaults?
http://guides.rubyonrails.org/i18n.html#defaults
Something like I18n.t(value, scope: "decidim.proposals.answers", default: :not_answered) should do the trick
oriolgual
previously approved these changes
Jul 19, 2017
oriolgual
approved these changes
Jul 19, 2017
beagleknight
added a commit
that referenced
this pull request
Jul 20, 2017
* Add proposal answer evaluating state * Add state evaluating to filters * Normalize locales * Add feedback
leio10
pushed a commit
to podemos-info/decidim
that referenced
this pull request
Jul 26, 2017
* Add proposal answer evaluating state * Add state evaluating to filters * Normalize locales * Add feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Added
evaluatingstate when answering a proposal.馃搶 Related Issues
None
馃搵 Subtasks
馃摲 Screenshots (optional)
馃懟 GIF
None