Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participatory process admins can invite to users to join a meeting #1879

Merged
merged 9 commits into from Sep 25, 2017

Conversation

@beagleknight
Copy link
Contributor

@beagleknight beagleknight commented Sep 19, 2017

馃帺 What? Why?

Participatory process admins can invite to users to join a meeting using an email. It works with registered and unregistered users.

馃搶 Related Issues

馃搵 Subtasks

  • Feature specs
  • Unregistered users
  • Registered users

馃摲 Screenshots (optional)

image
image
image
image

馃懟 GIF

@beagleknight beagleknight self-assigned this Sep 19, 2017
@ghost ghost added the in-progress label Sep 19, 2017
@codecov
Copy link

@codecov codecov bot commented Sep 19, 2017

Codecov Report

No coverage uploaded for pull request base (master@06c25fd). Click here to learn what that means.
The diff coverage is 98.9%.

@@            Coverage Diff            @@
##             master    #1879   +/-   ##
=========================================
  Coverage          ?   98.49%           
=========================================
  Files             ?     1133           
  Lines             ?    25502           
  Branches          ?        0           
=========================================
  Hits              ?    25117           
  Misses            ?      385           
  Partials          ?        0

@@ -267,6 +267,7 @@ en:
ignore: |-
If you don't want to accept the invitation, please ignore this email.<br />
Your account won't be created until you access the link above and set your password.
invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below."
Copy link
Contributor

@josepjaume josepjaume Sep 21, 2017

Correction: %{invited_by} has invited you to %{application}. You can accept the invitation through the link below:

Copy link
Contributor Author

@beagleknight beagleknight Sep 21, 2017

This is not even used lol 馃帀

@@ -267,6 +267,7 @@ en:
ignore: |-
If you don't want to accept the invitation, please ignore this email.<br />
Your account won't be created until you access the link above and set your password.
invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below."
invited_you_as_admin: "%{invited_by} has invited you as an admin of %{application}, you can accept it through the link below."
Copy link
Contributor

@josepjaume josepjaume Sep 21, 2017

Can you change this as well?

Copy link
Contributor Author

@beagleknight beagleknight Sep 21, 2017

You missed the correct line bro 馃槀

@@ -267,6 +267,7 @@ en:
ignore: |-
If you don't want to accept the invitation, please ignore this email.<br />
Your account won't be created until you access the link above and set your password.
invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below."
invited_you_as_admin: "%{invited_by} has invited you as an admin of %{application}, you can accept it through the link below."
someone_invited_you: Someone has invited you to %{application}, you can accept it through the link below.
Copy link
Contributor

@josepjaume josepjaume Sep 21, 2017

Aaand this? xD

Copy link
Contributor Author

@beagleknight beagleknight Sep 21, 2017

Ditto

@@ -45,6 +45,18 @@ en:
admin:
exports:
registrations: Registrations
invite_join_meeting_mailer:
invite:
invited_you_to_join_a_meeting: "%{invited_by} has invited you to join a meeting at %{application}, you can accept it through the link below."
Copy link
Contributor

@josepjaume josepjaume Sep 21, 2017

Please change this as per corrections suggested above 馃憤

Copy link
Contributor

@josepjaume josepjaume left a comment

I actually didn't want to approve but to request changes 馃棥


helper_method :routes

def invite(user, meeting, invited_by)
Copy link
Contributor

@mrcasals mrcasals Sep 21, 2017

Docs?

@beagleknight beagleknight dismissed josepjaume鈥檚 stale review Sep 25, 2017

I made the changes you requested.

@beagleknight beagleknight merged commit 8a13dc6 into master Sep 25, 2017
3 of 4 checks passed
@beagleknight beagleknight deleted the invite-to-join-meetings branch Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants