Participatory process admins can invite to users to join a meeting #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## master #1879 +/- ##
=========================================
Coverage ? 98.49%
=========================================
Files ? 1133
Lines ? 25502
Branches ? 0
=========================================
Hits ? 25117
Misses ? 385
Partials ? 0 |
beagleknight
force-pushed
the
invite-to-join-meetings
branch
from
3c3007e
to
e25e2e2
Compare
josepjaume
approved these changes
Sep 21, 2017
decidim-core/config/locales/en.yml
Outdated
| @@ -267,6 +267,7 @@ en: | |||
| ignore: |- | |||
| If you don't want to accept the invitation, please ignore this email.<br /> | |||
| Your account won't be created until you access the link above and set your password. | |||
| invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below." | |||
There was a problem hiding this comment.
Correction: %{invited_by} has invited you to %{application}. You can accept the invitation through the link below:
There was a problem hiding this comment.
This is not even used lol 🎉
decidim-core/config/locales/en.yml
Outdated
| @@ -267,6 +267,7 @@ en: | |||
| ignore: |- | |||
| If you don't want to accept the invitation, please ignore this email.<br /> | |||
| Your account won't be created until you access the link above and set your password. | |||
| invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below." | |||
| invited_you_as_admin: "%{invited_by} has invited you as an admin of %{application}, you can accept it through the link below." | |||
There was a problem hiding this comment.
Can you change this as well?
There was a problem hiding this comment.
You missed the correct line bro 😂
decidim-core/config/locales/en.yml
Outdated
| @@ -267,6 +267,7 @@ en: | |||
| ignore: |- | |||
| If you don't want to accept the invitation, please ignore this email.<br /> | |||
| Your account won't be created until you access the link above and set your password. | |||
| invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below." | |||
| invited_you_as_admin: "%{invited_by} has invited you as an admin of %{application}, you can accept it through the link below." | |||
| someone_invited_you: Someone has invited you to %{application}, you can accept it through the link below. | |||
| @@ -45,6 +45,18 @@ en: | |||
| admin: | |||
| exports: | |||
| registrations: Registrations | |||
| invite_join_meeting_mailer: | |||
| invite: | |||
| invited_you_to_join_a_meeting: "%{invited_by} has invited you to join a meeting at %{application}, you can accept it through the link below." | |||
There was a problem hiding this comment.
Please change this as per corrections suggested above 👍
josepjaume
previously requested changes
Sep 21, 2017
mrcasals
previously approved these changes
Sep 21, 2017
|
|
||
| helper_method :routes | ||
|
|
||
| def invite(user, meeting, invited_by) |
beagleknight
force-pushed
the
invite-to-join-meetings
branch
from
b0b8f8d
to
b054dac
Compare
oriolgual
approved these changes
Sep 25, 2017
beagleknight
dismissed
josepjaume’s stale review
I made the changes you requested.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Participatory process admins can invite to users to join a meeting using an email. It works with registered and unregistered users.
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)
👻 GIF