Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participatory process admins can invite to users to join a meeting #1879

Merged
merged 9 commits into from Sep 25, 2017

Conversation

Projects
None yet
4 participants
@beagleknight
Copy link
Contributor

commented Sep 19, 2017

馃帺 What? Why?

Participatory process admins can invite to users to join a meeting using an email. It works with registered and unregistered users.

馃搶 Related Issues

馃搵 Subtasks

  • Feature specs
  • Unregistered users
  • Registered users

馃摲 Screenshots (optional)

image
image
image
image

馃懟 GIF

@beagleknight beagleknight self-assigned this Sep 19, 2017

@ghost ghost added the in-progress label Sep 19, 2017

@codecov

This comment has been minimized.

Copy link

commented Sep 19, 2017

Codecov Report

鉂楋笍 No coverage uploaded for pull request base (master@06c25fd). Click here to learn what that means.
The diff coverage is 98.9%.

@@            Coverage Diff            @@
##             master    #1879   +/-   ##
=========================================
  Coverage          ?   98.49%           
=========================================
  Files             ?     1133           
  Lines             ?    25502           
  Branches          ?        0           
=========================================
  Hits              ?    25117           
  Misses            ?      385           
  Partials          ?        0

@beagleknight beagleknight force-pushed the invite-to-join-meetings branch from 3c3007e to e25e2e2 Sep 21, 2017

@beagleknight beagleknight added in-review and removed in-progress labels Sep 21, 2017

@@ -267,6 +267,7 @@ en:
ignore: |-
If you don't want to accept the invitation, please ignore this email.<br />
Your account won't be created until you access the link above and set your password.
invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below."

This comment has been minimized.

Copy link
@josepjaume

josepjaume Sep 21, 2017

Contributor

Correction: %{invited_by} has invited you to %{application}. You can accept the invitation through the link below:

This comment has been minimized.

Copy link
@beagleknight

beagleknight Sep 21, 2017

Author Contributor

This is not even used lol 馃帀

@@ -267,6 +267,7 @@ en:
ignore: |-
If you don't want to accept the invitation, please ignore this email.<br />
Your account won't be created until you access the link above and set your password.
invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below."
invited_you_as_admin: "%{invited_by} has invited you as an admin of %{application}, you can accept it through the link below."

This comment has been minimized.

Copy link
@josepjaume

josepjaume Sep 21, 2017

Contributor

Can you change this as well?

This comment has been minimized.

Copy link
@beagleknight

beagleknight Sep 21, 2017

Author Contributor

You missed the correct line bro 馃槀

@@ -267,6 +267,7 @@ en:
ignore: |-
If you don't want to accept the invitation, please ignore this email.<br />
Your account won't be created until you access the link above and set your password.
invited_you: "%{invited_by} has invited you to %{application}, you can accept it through the link below."
invited_you_as_admin: "%{invited_by} has invited you as an admin of %{application}, you can accept it through the link below."
someone_invited_you: Someone has invited you to %{application}, you can accept it through the link below.

This comment has been minimized.

Copy link
@josepjaume

josepjaume Sep 21, 2017

Contributor

Aaand this? xD

This comment has been minimized.

Copy link
@beagleknight

beagleknight Sep 21, 2017

Author Contributor

Ditto

@@ -45,6 +45,18 @@ en:
admin:
exports:
registrations: Registrations
invite_join_meeting_mailer:
invite:
invited_you_to_join_a_meeting: "%{invited_by} has invited you to join a meeting at %{application}, you can accept it through the link below."

This comment has been minimized.

Copy link
@josepjaume

josepjaume Sep 21, 2017

Contributor

Please change this as per corrections suggested above 馃憤

@josepjaume
Copy link
Contributor

left a comment

I actually didn't want to approve but to request changes 馃棥


helper_method :routes

def invite(user, meeting, invited_by)

This comment has been minimized.

Copy link
@mrcasals

mrcasals Sep 21, 2017

Contributor

Docs?

beagleknight added some commits Sep 19, 2017

I made the changes you requested.

@beagleknight beagleknight merged commit 8a13dc6 into master Sep 25, 2017

3 of 4 checks passed

codecov/project No report found to compare against
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch 98.9% of diff hit (target 50%)
Details

@beagleknight beagleknight deleted the invite-to-join-meetings branch Sep 25, 2017

@oriolgual oriolgual referenced this pull request Apr 24, 2018

Closed

Create design to manage minutes in a meeting #2862

0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.