Introduces an option to toggle the header snippets setting #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- defaults to true (enabled) to not break existing applications - new apps will have it disabled by default through the generated initializer.
mrcasals
suggested changes
Sep 25, 2017
| expect(organization.header_snippets).to_not be_present | ||
| end | ||
|
|
||
| it "saves header snippets if configured" do |
There was a problem hiding this comment.
Can you wrap this it inside a context?
context "when header snippets are configured" do
before do
allow(Decidim).to receive(:enable_html_header_snippets).and_return(true)
end
it "saves header snippets" do
...
end
end
|
Also, can you check the tests please? 馃槃 |
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
==========================================
+ Coverage 98.48% 98.48% +<.01%
==========================================
Files 1127 1127
Lines 25330 25351 +21
==========================================
+ Hits 24947 24968 +21
Misses 383 383 |
mrcasals
approved these changes
Sep 26, 2017
|
Thank you! 馃帀 Let's wait for the tests and we'll merge this 馃槃 |
|
Nice one, thanks @jkraemer |
|
Argh, I forgot to ask you for a CHANGELOG entry 馃槶 |
mrcasals
added a commit
that referenced
this pull request
Sep 26, 2017
|
See #1927 for the CHANGELOG entry. |
josepjaume
pushed a commit
that referenced
this pull request
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
As discussed in #1868 , here's a PR that introduces a setting to toggle the
header_snippetsfeature.I made it default to true (enabled) to not break existing applications, but new apps will have it disabled by default through the generated initializer.