Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil resource on StaticMapGenerator #1936

Merged
merged 2 commits into from
Sep 27, 2017

Conversation

mrcasals
Copy link
Contributor

馃帺 What? Why?

We have some Sentry issues reporting errors here. They are caused by search engine spiders, but it'd be good if we can avoid errors.

馃搶 Related Issues

None

馃搵 Subtasks

None

@mrcasals mrcasals self-assigned this Sep 27, 2017
josepjaume
josepjaume previously approved these changes Sep 27, 2017
@codecov
Copy link

codecov bot commented Sep 27, 2017

Codecov Report

Merging #1936 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1936      +/-   ##
==========================================
+ Coverage   98.48%   98.48%   +<.01%     
==========================================
  Files        1145     1145              
  Lines       25725    25734       +9     
==========================================
+ Hits        25336    25345       +9     
  Misses        389      389

@mrcasals mrcasals merged commit 7f4baf2 into master Sep 27, 2017
@mrcasals mrcasals deleted the fix/handle-nil-resource-static-map-generator branch September 27, 2017 09:27
@ghost ghost removed the in-review label Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants