Fix error when scope_id is a Hash
#1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
changed the title
scope_id is a Hash
beagleknight
previously approved these changes
Sep 27, 2017
mrcasals
force-pushed
the
fix/scope-select-bug
branch
from
4d9b6d1
to
cc2e93e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
- Coverage 98.48% 98.48% -0.01%
==========================================
Files 1145 1145
Lines 25734 25728 -6
==========================================
- Hits 25345 25338 -7
- Misses 389 390 +1 |
mrcasals
force-pushed
the
fix/scope-select-bug
branch
from
cc2e93e
to
15a8094
Compare
beagleknight
approved these changes
Sep 27, 2017
ghost
removed
the
mrcasals
added a commit
that referenced
this pull request
Sep 28, 2017
mrcasals
added a commit
that referenced
this pull request
Sep 28, 2017
* Show errors on the survey form (#1918) * Fix embed pages (#1929) * Fix embed pages * Add more tests * Add embed page test for proposals * Add embed specs for meetings * Add results embed page spec * Add embed specs for participatory spaces * Add CHANGELOG entries * Fix error when value is a Hash (#1937) * Add CHANGELOG entry for 0.6.5 * Bump version * Use latest docker image version on CircleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
We had some errors in Terrassa installation in the proposal filters. I could only reproduce this error by modifying the URL by hand. For some reason, Rails was treating a URL param that should have been an array as a Hash, and this was breaking the form.
This PR handles the case from the form builder side, as I could not reproduce the error on my development machine.
馃搶 Related Issues
None
馃搵 Subtasks
None