Hide "Mark all as read" button when no notifications #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
force-pushed
the
hide-button-when-no-notifications
branch
from
16fab5f
to
dbca533
Compare
josepjaume
previously requested changes
Sep 28, 2017
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| - **decidim-core**: Show a disabled "Follow" button to anonymous users (not logged in) with a prompt to sign in [\#1903](https://github.com/decidim/decidim/pull/1903) | |||
| - **decidim-core**: Adds an option to the initializer file to enable/disable header snippets (`true` by default) [\#1923](https://github.com/decidim/decidim/pull/1923) | |||
| - **decidim-core**: Hides the "MArkk all as read" notifications button whn no notifications are found [\#1948](https://github.com/decidim/decidim/pull/1948) | |||
There was a problem hiding this comment.
Two typos in a row, jackpot!
mrcasals
force-pushed
the
hide-button-when-no-notifications
branch
from
dbca533
to
10b54a3
Compare
|
@josepjaume solved everything! |
mrcasals
force-pushed
the
hide-button-when-no-notifications
branch
from
10b54a3
to
772b4b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1948 +/- ##
==========================================
+ Coverage 98.48% 98.48% +<.01%
==========================================
Files 1145 1145
Lines 25729 25730 +1
==========================================
+ Hits 25338 25339 +1
Misses 391 391 |
|
Rebased against master so that codecov would run (it was stuck) |
beagleknight
previously approved these changes
Oct 2, 2017
mrcasals
force-pushed
the
hide-button-when-no-notifications
branch
from
772b4b4
to
11db99b
Compare
beagleknight
approved these changes
Oct 4, 2017
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Hides the "Mark all as read" notifications button when no notifications are found.
馃搶 Related Issues
馃摲 Screenshots (optional)