Seed org with available authorizations #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
deivid-rodriguez
force-pushed
the
feature/seed_org_with_available_authorizations
branch
from
b7b1465
to
fd51e73
Compare
Codecov Report
@@ Coverage Diff @@
## master #1978 +/- ##
==========================================
- Coverage 98.48% 98.47% -0.01%
==========================================
Files 1145 1144 -1
Lines 25737 25722 -15
==========================================
- Hits 25346 25331 -15
Misses 391 391 |
deivid-rodriguez
force-pushed
the
feature/seed_org_with_available_authorizations
branch
from
fd51e73
to
bfade43
Compare
mrcasals
previously approved these changes
Oct 4, 2017
josepjaume
previously approved these changes
Oct 5, 2017
|
Should we add a CHANGELOG entry here? |
Transforming an existing application like this is very prone to errors and not that simple. For example, if there are existing authorization handlers already saved in DB (in either organizations or authorizations), they would need to be migrated or we would get crashes all around. So the current version of this generator is only ready to be used for direct app generator. So I merged it with the regular generator and made it accessible by passing the --demo flag to it.
deivid-rodriguez
dismissed stale reviews from josepjaume and mrcasals
via
f399e1e
deivid-rodriguez
force-pushed
the
feature/seed_org_with_available_authorizations
branch
from
bfade43
to
f399e1e
Compare
mrcasals
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
I'm doing a lot of manual testing with authorizations. Right now this is a bit tedious because the default organization is not seeded with the available handlers, so you have to go to /system, enable them, then go to admin and enable handlers for the actions, and then you can finally test the handler. This changes improve this by adding the available authorizations to the organization when seeding.
Since the "demo generator" (where the dummy authorization handler is setup) is run after seeding, I couldn't easily fix this by just adding it to seeds. So I decided to merge the demo generator with the main generator so by the time of seeding authorization handlers have been correctly setup. Instead, you can now pass
--demoto the generator if you want a demo handler (authorizes ID documents ended with "X"), or the default (an example handler with documentation that by default just authorizes everything).I think this is a good move anyways because:
bin/rails g decidim:demoon an existing application, running it can lead to crashes if there is existing authorization data in DB.馃搶 Related Issues
None.
馃搵 Subtasks
None.
馃摲 Screenshots (optional)
None.
馃懟 GIF