Require survey TOS field on admin #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beagleknight
previously approved these changes
Oct 4, 2017
Merged
mrcasals
force-pushed
the
fix/make-survey-tos-required
branch
from
24fef86
to
1722c9a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1980 +/- ##
==========================================
- Coverage 98.48% 98.47% -0.01%
==========================================
Files 1145 1128 -17
Lines 25730 25513 -217
==========================================
- Hits 25339 25124 -215
+ Misses 391 389 -2 |
beagleknight
approved these changes
Oct 4, 2017
ghost
removed
the
mrcasals
added a commit
that referenced
this pull request
Oct 5, 2017
* Require survey TOS field on admin * Add CHANGELOG entry
mrcasals
added a commit
that referenced
this pull request
Oct 5, 2017
* Don't use models in migrations (#1921) * Run seeds in the same process as migrations So we can detect bad model usage inside migrations. * Don't swallow errors in app generation The `rails_command` method shells out the target command, but swallows any errors that may happen. In my opinion, this is bad because we really want these commands to succeed, and since the output is usually long, you might not notice that they have failed. In addition, if errors are swallowed, it's really hard to unit test generators! * Remove hardcoded models from migrations And add a regression test for development app generation. To ensure that these errors can be properly caught in the future. * Prefer `abort` to `exit 1` * Remove unnecessary `ActiveRecord::Base.connection` In migrations, all that stuff in directly available. * Silence test output * Fix app generators (#1931) * Bundle less generator failure (#1938) * Fix crash when running decidim executable We can't asume bundler is available inside our generators, since it will not when they are run through decidim executable. Fixes the following crash: ``` /code/to/decidim/lib/generators/decidim/install_generator.rb:25:in `bundle_install': uninitialized constant Decidim::Generators::InstallGenerator::Bundler (NameError) ``` * Improve some test descriptions * Test generator without flags * Extract a shared example * Extract test app name to a variable And rename it so that specs don't fail on a freshly cloned repo (where ./tmp does not exist). * Allow DB dropping to fail For example, on freshly cloned repos. As a result, we no longer need to check for CI here. * Generate dev application in tests via bin/decidim So we can give it the standard "test name" and it doesn't affect our "real" development application. * Centralize dependencies (#1958) * Style fixes in template Gemfile * Centralize dependencies to a single Gemfile * Upgrade dependencies * Require survey TOS field on admin (#1980) * Require survey TOS field on admin * Add CHANGELOG entry * Fix puma dep * Fix input fields for single locale organizations (#1983) * Fix input fields for single locale organizations * Add CHANGELOG entry * Bump version to 0.6.6 * Downgrade graphiql-rails * Update CHANGELOG * Use latest docker image on CircleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Reported on #1976, see the discussion there. In the public form we are only showing the TOS checkbox if the text for that locale is present, but we are requiring the presence of it when submitting the form. This causes errors every time a user tries to submit a survey without TOS in that language.
To avoid this, I made the TOS field required and always show the TOS checkbox.
📌 Related Issues