Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hidden proposals on stats #1988

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Oct 5, 2017

🎩 What? Why?

Stats were taking into account the hidden proposals (that are hidden from Moderation), which caused proposal counts to differ.

This fixes it.

📌 Related Issues

@codecov
Copy link

codecov bot commented Oct 5, 2017

Codecov Report

Merging #1988 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
+ Coverage   98.47%   98.48%   +<.01%     
==========================================
  Files        1144     1144              
  Lines       25722    25755      +33     
==========================================
+ Hits        25331    25364      +33     
  Misses        391      391

@mrcasals mrcasals force-pushed the fix/ignore-hidden-proposals-on-stats branch from 500afbf to 1d26912 Compare October 5, 2017 12:50
Copy link
Contributor

@oriolgual oriolgual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specs?

@mrcasals mrcasals force-pushed the fix/ignore-hidden-proposals-on-stats branch 2 times, most recently from 24a42ac to 0a47425 Compare October 5, 2017 13:42
@mrcasals mrcasals force-pushed the fix/ignore-hidden-proposals-on-stats branch from 0a47425 to 5d51883 Compare October 5, 2017 13:45
Copy link
Contributor

@oriolgual oriolgual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@oriolgual oriolgual merged commit b1658a7 into master Oct 5, 2017
@oriolgual oriolgual deleted the fix/ignore-hidden-proposals-on-stats branch October 5, 2017 14:20
@ghost ghost removed the in-review label Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statistics of a process do not match the actual number of items
2 participants