Add votes column on proposals admin index #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
force-pushed
the
proposals/add-votes-column
branch
from
80359dd
to
1aa67a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2011 +/- ##
=========================================
Coverage ? 98.48%
=========================================
Files ? 1144
Lines ? 25776
Branches ? 0
=========================================
Hits ? 25385
Misses ? 391
Partials ? 0 |
| expect(page).to have_no_link("Answer") | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Is this new spec intended?
| ) | ||
| end | ||
|
|
||
| it "cannot answer a proposal" do |
There was a problem hiding this comment.
Wording here seems to not match the test.
| ) | ||
| end | ||
|
|
||
| it "cannot answer a proposal" do |
mrcasals
force-pushed
the
proposals/add-votes-column
branch
from
1aa67a0
to
3624108
Compare
|
@deivid-rodriguez fixed! I also added the CHANGELOG entry :) |
mrcasals
force-pushed
the
proposals/add-votes-column
branch
from
3624108
to
dad1447
Compare
josepjaume
approved these changes
Oct 10, 2017
josepjaume
approved these changes
Oct 11, 2017
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Add votes column on proposals list in the admin. We'll need this column in order to make the column sortable.
📌 Related Issues
📷 Screenshots (optional)