Don't use constants for authorization handlers configuration #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
+ Coverage 98.48% 98.48% +<.01%
==========================================
Files 1144 1145 +1
Lines 25754 25756 +2
==========================================
+ Hits 25363 25365 +2
Misses 391 391 |
mrcasals
suggested changes
Oct 10, 2017
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ | |||
| - **decidim**: URLs now use the participatory space slug instead of the ID, both in the public pages and in the admin. Old routes using the space IDs now redirect to the ones using the slug. [\#1842](https://github.com/decidim/decidim/pull/1842) | |||
| - **decidim**: `bin/rails generate decidim:demo` is no longer available in generated applications. Use the `--demo` flag when generating your application or do the change manually if you want to use the "demo" authorization handler. [\#1978](https://github.com/decidim/decidim/pull/1978) | |||
| - **decidim-core**: Changes some texts in the homepage ("How do I take part in a process?" section) [\#1947](https://github.com/decidim/decidim/pull/1947) | |||
| - **decidim-core**: Authorization handlers now must be specified as strings. To migrate, change `config.authorization_handlers = [MyHandler]` to `config.authorization_handlers = ["MyHandler"]`. [\#19](https://github.com/decidim/decidim/pull/19) | |||
There was a problem hiding this comment.
Ooops 馃槼, updated!
mrcasals
reviewed
Oct 10, 2017
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| <div class="field"> | |||
| <%= f.label :available_authorizations %> | |||
| <%= f.collection_check_boxes :available_authorizations, Decidim.authorization_handlers, :name, :name %> | |||
| <%= f.collection_check_boxes :available_authorizations, Decidim.authorization_handlers, :itself, :itself %> | |||
There was a problem hiding this comment.
itself?????????????? OMG I didn't know this existed 馃槶
There was a problem hiding this comment.
Pretty crazy, eh? Ruby style. I remember seeing it in docs or somewhere, but only now I found a use case.
There was a problem hiding this comment.
Sad & nice at the same time!
And set it just once before the whole suite.
So we don't depend on the constant being already available when configuration is read.
The handler is never supposed to be instantiated from the model and it's only used for validations. This changes make that more explicit.
deivid-rodriguez
force-pushed
the
fix/delay_constant_evaluation
branch
from
3d99d7e
to
95a32dc
Compare
josepjaume
approved these changes
Oct 10, 2017
mrcasals
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Tests on
decidim-barcelonarunning against currentdecidimmaster are failing because the authorization handler class is not yet available by the time tests are loaded.I think it's better to not use constants directly on code that is evaluated at initialization/load time, since we need to make sure the constants are actually available at the time. That's inconvenient because you never need to care about that in other situations, and I sometimes have seen it causing problems with code (auto)loading.
This is similar to Rails deprecating specifying
class_nameas a constant inActiveRecordassociations.This PR also includes some other refactorings in authorization handlers that I've extracted from another PR I'm working on (#1815 & #1871), to make reviewing that one easier.
馃搶 Related Issues
馃搵 Subtasks
None.
馃摲 Screenshots (optional)
None.
馃懟 GIF