Fix email notifications for new comments #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mrcasals
force-pushed
the
comments/fix-email-notificationns
branch
from
cd8c52c
to
54ad583
Compare
Codecov Report
@@ Coverage Diff @@
## master #2036 +/- ##
==========================================
+ Coverage 98.49% 98.52% +0.02%
==========================================
Files 1145 1145
Lines 25775 25797 +22
==========================================
+ Hits 25388 25417 +29
+ Misses 387 380 -7 |
oriolgual
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Email notifications for new comments were not being created correctly because of a bug in the code. This is now solved. This PR also rewords the email texts for this case, as they were weird.
馃搶 Related Issues
馃摲 Screenshots (optional)