Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appearance settings page #2041

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Add Appearance settings page #2041

merged 2 commits into from
Oct 16, 2017

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Oct 16, 2017

馃帺 What? Why?

This PR refactors the org settings page and splits it in two: Settings and Appearance.

馃摲 Screenshots (optional)

Configuration page:
localhost-3000-admin-organization-edit

Appearance page:
localhost-3000-admin-organization-appearance-edit

@codecov
Copy link

codecov bot commented Oct 16, 2017

Codecov Report

Merging #2041 into master will decrease coverage by <.01%.
The diff coverage is 98.25%.

@@            Coverage Diff             @@
##           master    #2041      +/-   ##
==========================================
- Coverage   98.56%   98.56%   -0.01%     
==========================================
  Files        1149     1155       +6     
  Lines       25941    26028      +87     
==========================================
+ Hits        25570    25654      +84     
- Misses        371      374       +3

This was generating `<label for="Current_image">` as HTML, which is weird.
@mrcasals mrcasals changed the title [WIP] Add Appearance settings page Add Appearance settings page Oct 16, 2017
@mrcasals mrcasals merged commit 21a349e into master Oct 16, 2017
@mrcasals mrcasals deleted the admin/cta-button-link branch October 16, 2017 13:26
@ghost ghost removed the in-review label Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants