Hide participatory space link from menu if no element is published #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
force-pushed
the
spaces/hide-link-from-menu-when-none-published
branch
from
ec9d640
to
54d8add
Compare
oriolgual
suggested changes
Oct 19, 2017
| @@ -55,6 +55,7 @@ class Engine < ::Rails::Engine | |||
| menu.item I18n.t("menu.assemblies", scope: "decidim"), | |||
| decidim_assemblies.assemblies_path, | |||
| position: 2.5, | |||
| if: Decidim::Assembly.published.any?, | |||
There was a problem hiding this comment.
Shouldn't this be scoped to the current organization?
| @@ -57,6 +57,7 @@ class Engine < ::Rails::Engine | |||
| menu.item I18n.t("menu.processes", scope: "decidim"), | |||
| decidim_participatory_processes.participatory_processes_path, | |||
| position: 2, | |||
| if: Decidim::ParticipatoryProcess.published.any?, | |||
mrcasals
force-pushed
the
spaces/hide-link-from-menu-when-none-published
branch
from
54d8add
to
d23262a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
+ Coverage 98.55% 98.56% +<.01%
==========================================
Files 1174 1174
Lines 26760 26766 +6
==========================================
+ Hits 26373 26381 +8
+ Misses 387 385 -2 |
|
@oriolgual solved! I've also added tests for the case you pointed out. |
oriolgual
previously approved these changes
Oct 19, 2017
josepjaume
suggested changes
Oct 19, 2017
mrcasals
changed the title
mrcasals
force-pushed
the
spaces/hide-link-from-menu-when-none-published
branch
from
d23262a
to
eaf8b77
Compare
josepjaume
previously approved these changes
Oct 19, 2017
mrcasals
force-pushed
the
spaces/hide-link-from-menu-when-none-published
branch
from
c3bdf10
to
dfcc081
Compare
oriolgual
approved these changes
Oct 20, 2017
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR hides the link to the spaces engine from the main menu if no element from that space is published. This means that if there are no published assemblies, there will be no link to the engine.
馃搶 Related Issues
馃摲 Screenshots (optional)
http://recordit.co/EGYedzRDvr
