Fix menu home highlight when using different locales

[mrcasals]

🎩 What? Why?

Fixes the menu Home element highlight when the user is logged in.

📌 Related Issues

None

📷 Screenshots (optional)

Before this PR:

http://recordit.co/3KFDe2Vwz4

After this PR:

http://recordit.co/VaaInJckOy

[deivid-rodriguez]

I think we have infrastructure to get this easily tested. See

decidim/decidim-core/spec/features/menu_spec.rb

Lines 1 to 58 in 3ef89f3

	# frozen_string_literal: true
	require "spec_helper"
	describe "Menu", type: :feature do
	let(:organization) { create(:organization) }
	before do
	switch_to_host(organization.host)
	visit decidim.root_path
	end
	matcher :have_selected_option do |expected|
	match do |page|
	page.has_selector?(".main-nav__link--active", count: 1) &&
	page.has_selector?(".main-nav__link--active", text: expected)
	end
	end
	it "renders the default main menu" do
	within ".main-nav" do
	expect(page).to \
	have_selector("li", count: 2) &
	have_link("Home", href: "/") &
	have_link("More information", href: "/pages")
	end
	end
	it "selects the correct default active option" do
	within ".main-nav" do
	expect(page).to have_selected_option("Home")
	end
	end
	context "when clicking on a menu entry" do
	before do
	click_link "More information"
	end
	it "switches the active option" do
	expect(page).to have_selected_option("More information")
	end
	context "and clicking on a subpage of that entry" do
	before do
	page = create(:static_page, organization: organization)
	visit current_path
	click_link page.title["en"]
	end
	it "preserves the active option" do
	expect(page).to have_selected_option("More information")
	end
	end
	end
	end

[codecov]

Codecov Report

Merging #2095 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
- Coverage   98.55%   98.54%   -0.02%     
==========================================
  Files        1174     1174              
  Lines       26836    26847      +11     
==========================================
+ Hits        26449    26456       +7     
- Misses        387      391       +4

[mrcasals]

@deivid-rodriguez I've added a test for this, test fails without the change in engine.rb 😄

[deivid-rodriguez]

Yuppi!