Add Excel format exporter #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mrcasals
reviewed
Oct 23, 2017
| @@ -16,13 +16,13 @@ class CSV < Exporter | |||
| # | |||
| # Returns an ExportData instance. | |||
| def export | |||
| data = ::CSV.generate(headers: headers, write_headers: true, col_sep: ";") do |csv| | |||
| data = ::CSV.generate(headers: headers, write_headers: true, col_sep: "\t") do |csv| | |||
There was a problem hiding this comment.
Separated with tabs? O_o'
There was a problem hiding this comment.
Excel is freaking weird, I'm looking at an alternate solution.
mrcasals
previously approved these changes
Oct 23, 2017
josepjaume
force-pushed
the
fix_csv_exporter
branch
from
a8d4cf9
to
2475484
Compare
Codecov Report
@@ Coverage Diff @@
## master #2099 +/- ##
==========================================
+ Coverage 98.55% 98.56% +<.01%
==========================================
Files 1174 1176 +2
Lines 26847 26889 +42
==========================================
+ Hits 26460 26502 +42
Misses 387 387 |
josepjaume
changed the title
mrcasals
reviewed
Oct 24, 2017
| @@ -5,14 +5,15 @@ module Exporters | |||
| autoload :Exporter, "decidim/exporters/exporter" | |||
| autoload :JSON, "decidim/exporters/json" | |||
| autoload :CSV, "decidim/exporters/csv" | |||
| autoload :Excel, "decidim/exporters/excel" | |||
| autoload :ExportData, "decidim/exporters/export_data" | |||
| autoload :Serializer, "decidim/exporters/serializer" | |||
|
|
|||
| # Get the exporter class constant from the format as a string. | |||
| # | |||
| # format - The exporter format as a string. i.e "csv" | |||
There was a problem hiding this comment.
Update the docs (upcase "CSV")?
mrcasals
reviewed
Oct 24, 2017
| @@ -10,7 +10,7 @@ class Exporter | |||
| # | |||
| # collection - An Array with the collection to be exported. | |||
| # serializer - A Serializer to be used during the export. | |||
| def initialize(collection, serializer) | |||
| def initialize(collection, serializer = Serializer) | |||
There was a problem hiding this comment.
What's this Serializer?? Is this something from our code?
There was a problem hiding this comment.
Yeah, it's a passthrough serializer, returns the object itself.
mrcasals
previously approved these changes
Oct 24, 2017
mrcasals
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This adds an explicit
Excelexporter that exports to a Spreadsheet instead of a CSV, which is causing lots of issues (mainly due to the undocumented nature of CSV itself).馃搶 Related Issues
None
馃搵 Subtasks
None
馃摲 Screenshots (optional)
None
馃懟 GIF
None