Disable autocomplete on password fields #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mrcasals
previously approved these changes
Oct 24, 2017
deivid-rodriguez
previously approved these changes
Oct 24, 2017
Codecov Report
@@ Coverage Diff @@
## master #2108 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 1177 1177
Lines 26933 26933
=======================================
Hits 26546 26546
Misses 387 387 |
[skip ci]
josepjaume
dismissed stale reviews from deivid-rodriguez and mrcasals
via
301e299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This disables autocomplete on password fields to prevent a weird behavior on
Firefoxand potentially any other browsers that store passwords.馃搶 Related Issues
馃搵 Subtasks
None
馃摲 Screenshots (optional)
None
馃懟 GIF