Fix duplicated conversations #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@xabier @carolromero is this the error related to messages you were talking about? |
Codecov Report
@@ Coverage Diff @@
## master #2376 +/- ##
==========================================
+ Coverage 95.49% 98.62% +3.12%
==========================================
Files 1103 1273 +170
Lines 24456 29437 +4981
==========================================
+ Hits 23354 29031 +5677
+ Misses 1102 406 -696 |
josepjaume
approved these changes
Dec 14, 2017
josepjaume
pushed a commit
that referenced
this pull request
Dec 15, 2017
* Privatize helper section * Redirect to existing conversation if it exists
josepjaume
added a commit
that referenced
this pull request
Dec 15, 2017
* Fix duplicated conversations (#2376) * Privatize helper section * Redirect to existing conversation if it exists * Fix migration on permissions (#2373) * Fix migration permissions * Add changelog entry * Do not allow attachments onn proposal edit (#2374) * Do not allow attachments onn proposal edit * Fix CHANGELOG * Add CHANGELOG entry * Remove unused i18n key * Restore js tests in CI and fix them (#2371) * select2 4.0.5 has changes that break our tests :S * package.json version was incorrect. * Add conversations to side menu (#2364) So that they are accessible in mobile devices. * Fix translations * Version bump
|
@josepjaume yes that's the one we spotted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR prevents the creation of many conversation with the same participants at the UI level. Since things are prepared at a lower level to actually permit this (for a future "conversation groups" feature), I don't think this is worth enforcing at a lower level.
馃搶 Related Issues
馃搵 Subtasks
None.
馃摲 Screenshots (optional)
None.
馃懟 GIF