Allow underscores at CTA button path #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
oriolgual
force-pushed
the
fix/cta_path_with_underscores
branch
from
ed1e77d
to
4b5725e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2625 +/- ##
==========================================
+ Coverage 98.81% 98.81% +<.01%
==========================================
Files 1434 1434
Lines 33477 33480 +3
==========================================
+ Hits 33081 33084 +3
Misses 396 396 |
oriolgual
force-pushed
the
fix/cta_path_with_underscores
branch
from
4b5725e
to
6c5f6fd
Compare
mrcasals
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
It was missing the underscore at the regex.
📌 Related Issues