Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nicknames [backport 0.9] #2789

Merged
merged 1 commit into from Feb 22, 2018
Merged

Fix nicknames [backport 0.9] #2789

merged 1 commit into from Feb 22, 2018

Conversation

josepjaume
Copy link
Contributor

🎩 What? Why?

Backports #2783 into 0.9-stable.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry

📷 Screenshots (optional)

None

@ghost ghost assigned josepjaume Feb 21, 2018
@ghost ghost added the in-progress label Feb 21, 2018
@josepjaume josepjaume changed the base branch from master to 0.9-stable February 21, 2018 14:55
* Create nickname before saving and fix migrations

* Fix nicknamizable
@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (0.9-stable@7faf8f5). Click here to learn what that means.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             0.9-stable    #2789   +/-   ##
=============================================
  Coverage              ?   98.85%           
=============================================
  Files                 ?     1438           
  Lines                 ?    33842           
  Branches              ?        0           
=============================================
  Hits                  ?    33454           
  Misses                ?      388           
  Partials              ?        0

@oriolgual oriolgual merged commit ed00cb7 into 0.9-stable Feb 22, 2018
@ghost ghost removed the in-review label Feb 22, 2018
@oriolgual oriolgual deleted the backport/fix_nicknames branch February 22, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants