Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mentions not working properly #2947

Merged
merged 3 commits into from
Mar 12, 2018
Merged

Fix mentions not working properly #2947

merged 3 commits into from
Mar 12, 2018

Conversation

rbngzlv
Copy link
Contributor

@rbngzlv rbngzlv commented Mar 7, 2018

馃帺 What? Why?

Mentions in comments are not working properly because the GraphQL mutation was not setting the context correctly.

馃搶 Related Issues

馃搶 Related PR

馃搵 Subtasks

  • Add CHANGELOG entry
  • Backport to 0.9-stable
  • Backport to 0.10-stable

@ghost ghost assigned rbngzlv Mar 7, 2018
@ghost ghost added the in-progress label Mar 7, 2018
@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #2947 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
+ Coverage   98.72%   98.72%   +<.01%     
==========================================
  Files        1666     1666              
  Lines       39661    39686      +25     
==========================================
+ Hits        39156    39181      +25     
  Misses        505      505

@rbngzlv
Copy link
Contributor Author

rbngzlv commented Mar 7, 2018

@decidim/lot-core ready to review.

@deivid-rodriguez
Copy link
Contributor

@rbngzlv It'd be possible to add a system spec for this?

Copy link
Contributor

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, current specs are too flaky (this is why this bug appeared in the first place). We should add a system test for this.

@rbngzlv
Copy link
Contributor Author

rbngzlv commented Mar 12, 2018

@deivid-rodriguez @josepjaume rebased on master and added a system spec.

@josepjaume
Copy link
Contributor

@rbngzlv backporting to 0.10 is necessary but I believe 0.9 is not, right?

@josepjaume josepjaume merged commit 6c78287 into master Mar 12, 2018
@ghost ghost removed the in-review label Mar 12, 2018
@josepjaume josepjaume deleted the fix/mentions_graphql branch March 12, 2018 09:36
@rbngzlv
Copy link
Contributor Author

rbngzlv commented Mar 12, 2018

@josepjaume I'm not sure, the bug was detected in 0.9. Definitively we need a policy for the EOL of the previous versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants