-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mentions not working properly #2947
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
+ Coverage 98.72% 98.72% +<.01%
==========================================
Files 1666 1666
Lines 39661 39686 +25
==========================================
+ Hits 39156 39181 +25
Misses 505 505 |
@decidim/lot-core ready to review. |
@rbngzlv It'd be possible to add a system spec for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, current specs are too flaky (this is why this bug appeared in the first place). We should add a system test for this.
1aafb71
to
f157efd
Compare
@deivid-rodriguez @josepjaume rebased on master and added a system spec. |
@rbngzlv backporting to |
@josepjaume I'm not sure, the bug was detected in |
馃帺 What? Why?
Mentions in comments are not working properly because the GraphQL mutation was not setting the context correctly.
馃搶 Related Issues
馃搶 Related PR
0.9-stable
: PENDING0.10-stable
: [Backport] Fix mentions not working properly聽#2972馃搵 Subtasks
CHANGELOG
entry0.9-stable
0.10-stable