[WIP]Add fields to meetings #3080
Conversation
ghost
assigned 
| @@ -55,6 +55,11 @@ def copy_meeting! | |||
| component: @meeting.component, | |||
| registrations_enabled: @meeting.registrations_enabled, | |||
| available_slots: @meeting.available_slots, | |||
| has_conciliation_service: @form.has_conciliation_service, | |||
There was a problem hiding this comment.
I don't have a technical issue with this, but maybe conciliation is not the right term?
Conciliation: "the action of stopping someone from being angry; placation."
Maybe family friendly space or childcare service would make more sense @decidim/product ?
There was a problem hiding this comment.
@decidim/lot-core According with @decidim/product we decide to change the admin functionality with a jsonb field, called for example 'services_offered' and store in them the information of the services. They can add up to 4. Any help on how to do it will be helpful 馃槂
There was a problem hiding this comment.
I'd say the adding this limit (4) might add a lot of complexity, and since this is something only admins will use I wouldn't limit it.
There was a problem hiding this comment.
What do you propose? Are you agree to use a jsonb field with all the services with translations? Or do you think there's a better way?
There was a problem hiding this comment.
I'm OK with using a JSONb field, but without limiting the number of services
Codecov Report
@@ Coverage Diff @@
## master #3080 +/- ##
=========================================
+ Coverage 98.6% 98.6% +<.01%
=========================================
Files 1718 1718
Lines 41076 41094 +18
=========================================
+ Hits 40502 40520 +18
Misses 574 574 |
|
Closing in favor of #3150. |
馃帺 What? Why?
This PR adds new fields to meetings.
馃搶 Related Issues
馃搵 Subtasks
CHANGELOGentry