More survey improvements #3133
Merged
More survey improvements #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
1 task
deivid-rodriguez
force-pushed
the
more_survey_improvements
branch
from
94a47d9
to
e4f3272
Compare
|
@deivid-rodriguez after merging #3091 I'm getting conflicts 馃槥 |
Since it might be different depending on the type of field. For example, for a text field dependent on a checkbox, we'll need to check the "checked" property of the checkbox, not its value.
Keeping them on a single column is weird and very unflexible.
Answer is a different model not involved here, so this version is less confusing, I think.
This is a similar refactoring to what was done in the backend. Instead of using isolated form helpers, use a proper form builder. This came with the fix/feature of adding proper support for client side validations, improving user experience and reducing server load.
deivid-rodriguez
force-pushed
the
more_survey_improvements
branch
from
e4f3272
to
3a13d5c
Compare
|
Fixed, sorry about that, I'm not sure why all those conflicts are generated on my "PRs on top of PRs"... 馃槥 |
|
Data migrations are tough, I found a few problems in the migration introduced in this PR. Keeping the WIP label until I get to fix them! |
@deivid-rodriguez maybe it's due to squashing the commits on merge? 馃槙 |
|
I hadn't think about that, and it would make sense indeed... |
PostgreSQL casting was saving the new text bodies as "\"value\"".
deivid-rodriguez
force-pushed
the
more_survey_improvements
branch
from
9682b34
to
0b317e1
Compare
|
Fixed the migration and a few more issues regarding field disabling. Should be ready now. |
josepjaume
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR sits on top of #3091. It keeps refactoring surveys (mainly the frontend), and adds a couple of noticiable changes:
馃搶 Related Issues
None.
馃搵 Subtasks
CHANGELOGentry馃摲 Screenshots (optional)
None.