Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue editing and deleting a specific post #3329

Merged
merged 5 commits into from
May 8, 2018

Conversation

isaacmg410
Copy link
Contributor

@isaacmg410 isaacmg410 commented May 3, 2018

馃帺 What? Why?

Fix when and admin try to edit a old post in the admin view he can edit only the last one.
Also, occurse the same with delete option.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add params[:id] when searching post.

馃摲 Screenshots (optional)

Description

@ghost ghost assigned isaacmg410 May 3, 2018
@ghost ghost added the status: WIP label May 3, 2018
@isaacmg410
Copy link
Contributor Author

@decidim/lot-core should this be backported?

@mrcasals
Copy link
Contributor

mrcasals commented May 3, 2018

@isaacmg410 yes, please!

mrcasals
mrcasals previously approved these changes May 3, 2018
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality is very basic, I think it merits a test that fails without this change.

@isaacmg410
Copy link
Contributor Author

Tests Added.

@isaacmg410
Copy link
Contributor Author

@mrcasals backport to 0.11? or 0.10?

@mrcasals
Copy link
Contributor

mrcasals commented May 4, 2018

@isaacmg410 0.11, please!

/cc @josepjaume

@ghost ghost assigned oriolgual May 4, 2018
@ghost ghost added the status: WIP label May 4, 2018
@oriolgual
Copy link
Contributor

I've fixed conflicts with the changelog

@mrcasals mrcasals merged commit 92de9f0 into master May 8, 2018
@ghost ghost removed the status: WIP label May 8, 2018
@mrcasals mrcasals deleted the fix_edit_delete_specific_post branch May 8, 2018 07:24
isaacmg410 pushed a commit to CodiTramuntana/decidim that referenced this pull request May 25, 2018
* add id when search post

* add changelog

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants