Fix dummy app generation from end apps #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to know, `development_app` and `spec/decidim_dummy_app` would share their DBs, so regenerating the test app would drop your development app DB (or would fail if your development application is running), and viceverse. These are separate applications so they really shouldn't interfere with each other. This patch also generate different DB names for external plugins since the base name for the app is inferred from the root folder name, so it makes a previous fix to configure the test DB and development DB names separately unnecessary.
Otherwise one gets ``` Invalid application name decidim_barcelona, constant DecidimBarcelona is already in use. Please choose another application name. ```
ghost
assigned 
deivid-rodriguez
added
backport
mrcasals
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Hei! I'm backporting the fix for dummy application generation from final apps, which works correctly on master, but it's broken on
0.11.1. The PR that fixes it includes plenty of other changes, including the removal of a couple of environment variables which could be considered as breaking (although there's also an argument to call them buggy and consider it a bug fix). Anyways, I selectively picked the single two commits from that PR so that only the bug fix mentioned in the PR title is backported.You were probably going to run into this when upgrading
decidim-barcelonato 0.11.I could add a regression test for this, but due to how our current generator tests work (they only assert the exit status of the generator, and to a bug in thor, the test will always pass, with or without these changes... :(
馃搶 Related Issues
馃搵 Subtasks
CHANGELOGentry馃摲 Screenshots (optional)
None.