[FIX] Do not link when there are no endorsements. #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
oriolgual
suggested changes
May 29, 2018
| @@ -1,4 +1,4 @@ | |||
| <%= link_to "#list-of-endorsements", id: "proposal-#{proposal.id}-endorsements-count", class: "button small compact light button--sc button--shadow #{fully_endorsed ? 'success' : 'secondary'}" do %> | |||
| <%= link_to "#{proposal.proposal_endorsements_count.positive? ? "#list-of-endorsements" : "javascript:;"}", id: "proposal-#{proposal.id}-endorsements-count", class: "button small compact light button--sc button--shadow #{fully_endorsed ? 'success' : 'secondary'}" do %> | |||
There was a problem hiding this comment.
Maybe we should use link_to_if here or not render the link at all?
There was a problem hiding this comment.
I can use a variable if you don't like this inliner:
<% link_href= proposal.proposal_endorsements_count.positive? ? "#list-of-endorsements" : "javascript:;" %>
+<%= link_to link_href, id: "proposal-#{proposal.id}-endorsements-count", class: "button small compact light button--sc button--shadow #{fully_endorsed ? 'success' : 'secondary'}" do %>
There was a problem hiding this comment.
The problem is not the inline ternary operator, but the link to javascript:;, which looks weird to me
There was a problem hiding this comment.
Indeed, but it is solution to the problem that avoids having to hack the CSSs.
There was a problem hiding this comment.
@tramuntanal You don't need to hack the CSS here. You can apply those classes to a div and it will look exactly the same 😄
tramuntanal
force-pushed
the
fix/3322-endorsements_num_icon_scrolls_down_to_endorsements_list_when_no_endorsements_exist
branch
from
3c44b67
to
6a62957
Compare
oriolgual
previously approved these changes
Jun 6, 2018
|
It seems that coverage checks are stalled @decidim/lot-core |
|
This PR is ready to be merged @decidim/lot-core :) |
mrcasals
force-pushed
the
fix/3322-endorsements_num_icon_scrolls_down_to_endorsements_list_when_no_endorsements_exist
branch
from
b46003f
to
7b8a672
Compare
mrcasals
approved these changes
Jun 7, 2018
mrcasals
deleted the
fix/3322-endorsements_num_icon_scrolls_down_to_endorsements_list_when_no_endorsements_exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
There is a strange behaviour when clicking on icon next to endorse button.
📌 Related Issues
📋 Subtasks
CHANGELOGentry