Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send notifications to users without access to the space #3542

Merged
merged 2 commits into from
Jun 4, 2018

Conversation

rbngzlv
Copy link
Contributor

@rbngzlv rbngzlv commented May 30, 2018

馃帺 What? Why?

If an User A follows an User B, User A receives notifications for actions that User B has done in private spaces.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry

@ghost ghost assigned rbngzlv May 30, 2018
@ghost ghost added the status: WIP label May 30, 2018
@rbngzlv rbngzlv force-pushed the fix/notifications_for_private_spaces branch from 95d98d8 to eb6815c Compare May 30, 2018 09:02
@rbngzlv rbngzlv changed the title Don't send notifications to users without access to the private space Don't send notifications to users without access to the space Jun 1, 2018
@rbngzlv
Copy link
Contributor Author

rbngzlv commented Jun 1, 2018

@decidim/lot-core can you review, please?

@mrcasals mrcasals merged commit ee9dd01 into master Jun 4, 2018
@mrcasals mrcasals deleted the fix/notifications_for_private_spaces branch June 4, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants