-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proposal date shown to published_at #3649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I was not aware we were using it in so many places, good job @agustibr! 😄
Jaja, I also discovered all cases on the progress 😅 ❓ @mrcasals there's one more case, it's the currently failing test, because of the proposal preview step in the wizard, at that point there's no
|
@agustibr I'd remove the cell (option 1). Maybe it even makes sense to remove the whole status section, since draft proposals can't be endorsed nor commented, so that data makes no sense. What do you think? 😄 |
hi, I don't have strong opinion. Simplest option 1 seems ok. |
@xabier thanks for your response, ok I'll remove the |
8ec89c0
to
c93c64d
Compare
@mrcasals, PR ready to merge! 😬 |
👏 |
🎩 What? Why?
Creation date is shown for
Proposal
in: card, detail, admin component index and when exported.But the relevant date is the Publication date, this PR solves this issues
📌 Related Issues
📋 Subtasks
CHANGELOG
entryproposal_m_cell_spec.rb
proposals_spec.rb
created_at
topublished_at
:📷 Screenshots (optional)