Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let nicknames be scoped #3671

Merged
merged 6 commits into from
Jun 15, 2018
Merged

Let nicknames be scoped #3671

merged 6 commits into from
Jun 15, 2018

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Jun 14, 2018

馃帺 What? Why?

This PR lets the Nicknamizable module accept scopes so that nicknames don't have to be unique per installation. This allows the same person, in a multi-tenant installation, use the same nickname in different orgs.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry

@mrcasals mrcasals self-assigned this Jun 14, 2018
@ghost ghost added the status: WIP label Jun 14, 2018
@mrcasals mrcasals changed the title Fix/scope nicknames Let nicknames be scoped Jun 14, 2018
@oriolgual oriolgual merged commit 8265658 into master Jun 15, 2018
@oriolgual oriolgual deleted the fix/scope-nicknames branch June 15, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants