Add readonly attribute to date_field so that user can not fill it manually #3705
Conversation
ghost
assigned 
CHANGELOG.md
Outdated
| @@ -66,6 +66,7 @@ Decidim::Organization.find_each { |organization| Decidim::System::CreateDefaultP | |||
|
|
|||
| **Added**: | |||
|
|
|||
| **decidim-core**: Add readonly attribute to date_fields so that the user is forced to use the datepicker. [#3705](https://github.com/CodiTramuntana/decidim/pull/3705) | |||
There was a problem hiding this comment.
the url is correct? should not be "https://github.com/decidim/decidim/pull/3705" ?
There was a problem hiding this comment.
You are totally right!
|
The failing test is passing locally. May "unknown error: Chrome failed to start: exited abnormally" be a random test failure? can @decidim/lot-core re-execute it please? |
|
It worked! Ready to review and merge @decidim/lot-core ! |
Can you elaborate on this @tramuntanal ? |
|
Hi @oriolgual , My idea is to allow users to enter the date manually in their locale format and then, make controllers parse this strings to date before the parameter goes deeper into the business application logic. |
oriolgual
deleted the
fix/3574-date_field_doesnt_work_when_date_is_entered_manually-readonly
branch
…ually (decidim#3705) * Add readonly attribute to date_field so that user can not fill it manually. * Add Changelog entry. * [FIX] URL for PR in changelog was incorrect.
🎩 What? Why?
On the public side, in a date_field field if the date is entered manually (without using the calendar widget) this is not copied to the value of the hidden input that is sent.
By making the visible text field readonly the user will be forced to use the calendar widget avoiding the problem.
This is a fast bugfix expected to be added to 0.12.1. Will work on a better solution for 0.13.0.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)