Pass the current component to the action authorizer #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
leio10
force-pushed
the
enhancement/add_component_to_authorization
branch
from
2238994
to
54a4c38
Compare
leio10
changed the title
|
@deivid-rodriguez do you want to review this? |
deivid-rodriguez
approved these changes
Jun 25, 2018
|
Wohoo! 馃挭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR slightly modifies the authorization process, adding a reference to the component where the authorization is taking place to the
DefaultActionAuthorizerthat will perform the authorization process.This reference is not used by any code, but it can be used by a custom action authorizer. In my case,
I need to check that the user's scope is included in the participatory space's scope to perform the authorization. With this PR I can find it out from the current component reference and compare it with the user's scope.
馃搶 Related Issues
馃搵 Subtasks
CHANGELOGentry