Notification settings show Newsletter always as "not subscribed" #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- otherwise the current state is displayed wrong in the notification settings, always showing unsubscribed state
ghost
added
the
mrcasals
approved these changes
Oct 5, 2018
|
@jkraemer thanks for the PR! Merging it right away! |
tramuntanal
pushed a commit
that referenced
this pull request
Oct 9, 2018
* properly initialize newsletter_notifications form attribute - otherwise the current state is displayed wrong in the notification settings, always showing unsubscribed state * changelog entry for #4238 (newsletter subscription checkbox state)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When subscribing to the newsletter in Account / Notification Settings by toggling the switch labelled I want to receive newsletters and submitting the form, the new state initially is shown (and saved) correctly. When revisiting the page (click Notification settings in sidebar again), the switch is off again.
Reason and Fix
The reason for that is that the form object's
newsletter_subscriptionattribute is not initialized when it is created from the user model. The patch adds a correspondingfrom_modelimplementation.